Skip to content

chore: psalm config #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2022
Merged

chore: psalm config #6875

merged 3 commits into from
Nov 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 17, 2022 •
edited
Loading

Description
See #6534

  • add baseline

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis
fix: restore current directory
a746a2f 
baseline.xml was created in system/Helpers/.
@kenjis
docs: add @phpstan-var
872536c
@kenjis
chore: add psalm-baseline.xml
61fe138 
vendor/bin/psalm --set-baseline=psalm-baseline.xml
@kenjis kenjis added the 4.3 label Nov 17, 2022
MGatner
MGatner approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I didn't know you could baseline in Psalm

@kenjis kenjis merged commit fd5c156 into codeigniter4:4.3 Nov 18, 2022
@kenjis kenjis deleted the fix-psalm-errors branch November 18, 2022 01:14
@kenjis kenjis mentioned this pull request Nov 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner