feat: Language translations finder and update

[neznaika0]

Description
See thread https://forum.codeigniter.com/showthread.php?tid=88299
Ready to discuss the solution

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[neznaika0]

I fixed typehint for PHP 7.4

[kenjis]

Fix broken tests. https://github.com/codeigniter4/CodeIgniter4/actions/runs/6057011818/job/16438443140?pr=7889

[kenjis]

Run vendor/bin/rector process {file_path}.
https://github.com/codeigniter4/CodeIgniter4/actions/runs/6057011803/job/16438441396?pr=7889

[neznaika0]

There is a conflict between the Rector and php-cs-fixer (pre-commit). The rector erases the indents in the method, and php-cs-fixer adds.

      ---------- begin diff ----------
--- /home/aleksandr/www/codeigniter/tests/system/Commands/Translation/LocalizationFinderTest.php
+++ /home/aleksandr/www/codeigniter/tests/system/Commands/Translation/LocalizationFinderTest.php
@@ -149,33 +149,33 @@
     private function getActualTableWithNewKeys(): string
     {
         return <<<'TEXT_WRAP'
-+------------------+----------------------------------------------------+
-| File             | Key                                                |
-+------------------+----------------------------------------------------+
-| TranslationOne   | TranslationOne.Copyright                           |
...many lines
-| TranslationThree | TranslationThree.formFields.new.short_tag          |
-+------------------+----------------------------------------------------+
-TEXT_WRAP;
+            +------------------+----------------------------------------------------+
+            | File             | Key                                                |
+            +------------------+----------------------------------------------------+
+            | TranslationOne   | TranslationOne.Copyright                           |
...many lines
+            | TranslationThree | TranslationThree.formFields.new.short_tag          |
+            +------------------+----------------------------------------------------+
+            TEXT_WRAP;
     }
 
     private function realizeAssertion(): void

      ----------- end diff -----------

EDIT: Should I move files from Controllers/Translation to another location? This violates the router's tests

[kenjis]

The conflict is not a problem. We always need to run composer cs-fix after refactoring by rector.

[kenjis]

Should I move files from Controllers/Translation to another location? This violates the router's tests

If possible, it is better.
Or update the failed tests.

[neznaika0]

I moved it to another folder with examples.
Added some description in the guide.

Is it possible to get an assessment of the work, is it worth continuing? Or will the function be rejected after the tests?

[kenjis]

We have not yet reviewed the contents of the code because the GitHub Action checks have not passed.

However, this feature is useful and I would like to include it in 4.5.

[ddevsr]

I would like use

Suggested change

	$tableRows = array_merge($this->arrayToTableRows($langFileName, $languageDiff), $tableRows);
	$tableRows = [$this->arrayToTableRows($langFileName, $languageDiff), $tableRows];

Ref : https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#arraymergeofnonarraystosimplearrayrector

[neznaika0]

No. Read the instructions carefully.
You are trying to merge two arrays, and the documentation talks about strings. This will result in an error.

• I applied the Rector before the commit

[neznaika0]

Oops. My commit has merged with the develop branch. Is it ugly? Do I now need a branch from 4.5 and not develop?

I added to PR dashed keys search as lang('Lang-File.dashed.key-with-dash')