Skip to content

docs: fix incorrect sample code in ajax.rst #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 2, 2023

Description
It is not valid that "application/json" and "GET".
The HTTP method names are case-sensitive, and it is not "get" but "GET".

The method token is case-sensitive because it might be used as a gateway to object-based systems with case-sensitive method names. By convention, standardized methods are defined in all-uppercase US-ASCII letters.
https://www.rfc-editor.org/rfc/rfc9110#name-overview

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

It is not valid that "application/json" and "GET".
@kenjis kenjis merged commit 45ee333 into codeigniter4:develop Nov 5, 2023
@kenjis kenjis deleted the docs-fix-ajax branch November 5, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants