Skip to content

[4.5] test: fix ShowTableInfoTest::testDbTableShowsDBConfig() #8137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 3, 2023

Description

  • fix test that waits user input forever
$ php spark db:table

CodeIgniter v4.4.3 Command Line Tool - Server Time: 2023-11-03 04:34:35 UTC+00:00

+-----------+----------+----------+----------+----------+------+
| hostname  | database | username | DBDriver | DBPrefix | port |
+-----------+----------+----------+----------+----------+------+
| localhost | ci4      | root     | MySQLi   |          | 3306 |
+-----------+----------+----------+----------+----------+------+

Here is the list of your database tables:
  [0]  migrations

Which table do you want to see? 0: 

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only 4.5 labels Nov 3, 2023
@kenjis
Copy link
Member Author

kenjis commented Nov 5, 2023

Can someone approve this?

@kenjis kenjis mentioned this pull request Nov 5, 2023
5 tasks
@kenjis kenjis merged commit d7272b8 into codeigniter4:4.5 Nov 5, 2023
@kenjis kenjis deleted the test-fix-ShowTableInfoTest branch November 5, 2023 07:47
@kenjis
Copy link
Member Author

kenjis commented Nov 5, 2023

@neznaika0 Thank you for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants