Skip to content

docs: make note for spark routes and filters more accurate #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

docs: make note for spark routes and filters more accurate #8178

merged 1 commit into from
Nov 10, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 8, 2023 •
edited
Loading

Description
The current description is inaccurate.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 8, 2023
@kenjis kenjis mentioned this pull request Nov 8, 2023
Closed
5 tasks
datamweb
datamweb approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explanation.👍

@kenjis kenjis merged commit 0ab4d67 into codeigniter4:develop Nov 10, 2023
@kenjis kenjis deleted the docs-fix-routes-filter-output branch November 10, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb