Skip to content

test: fix failed ValidationTest #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 19, 2023

Description

Error: tests/system/Validation/ValidationTest.php:800:53: UndefinedClass: Class, interface or enum named CodeIgniter\Validation\URI does not exist (see https://psalm.dev/019)

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6916967990/job/18817589705

1) CodeIgniter\Validation\StrictRules\ValidationTest::testJsonInputInvalid
Failed asserting that exception of type "Error" matches expected exception "CodeIgniter\HTTP\Exceptions\HTTPException". Message was: "Class "CodeIgniter\Validation\URI" not found" at
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php:800
.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6916968004/job/18817590692
Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Nov 19, 2023
@kenjis
Copy link
Member Author

kenjis commented Nov 19, 2023

Now GitHub Action checks fail.
Review this first.

@kenjis kenjis merged commit 14b7679 into codeigniter4:develop Nov 19, 2023
@kenjis kenjis deleted the fix-ValidationTest branch November 19, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants