Skip to content

docs: fix incorrect PHPDoc types #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2023
Merged

docs: fix incorrect PHPDoc types #8244

merged 1 commit into from
Nov 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 23, 2023 •
edited
Loading

Description

  • fix PHPDoc type errors found by Psalm

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis force-pushed the fix-phpdoc-types-for-psalm branch from 41b564b to 0c7b1c7 Compare November 23, 2023 12:18
@kenjis kenjis force-pushed the fix-phpdoc-types-for-psalm branch from 0c7b1c7 to 49ac664 Compare November 23, 2023 12:20
@kenjis
Copy link
Member Author

kenjis commented Nov 25, 2023

This PR fixes the current Psalm errors. Review first.

@kenjis kenjis merged commit e346a6f into codeigniter4:develop Nov 25, 2023
@kenjis kenjis deleted the fix-phpdoc-types-for-psalm branch November 25, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan