Skip to content

docs: improve pagination #8256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 26, 2023

Description
Fixes #8254

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@sammyskills
Copy link
Contributor

Can it be stated in the docs, how to get the entire dataset's first and last page numbers? Something along the lines of this #8254 (comment)

@kenjis kenjis force-pushed the docs-improve-pagination branch from 4d40a81 to 066bbbd Compare November 26, 2023 20:54
@kenjis
Copy link
Member Author

kenjis commented Nov 26, 2023

@sammyskills Added 066bbbd

Co-authored-by: Samuel Asor <[email protected]>
@kenjis kenjis merged commit 93e9c6b into codeigniter4:develop Nov 28, 2023
@kenjis kenjis deleted the docs-improve-pagination branch November 28, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pagination getFirstPageNumber() & getLastPageNumber() returns unexpected result.
3 participants