Skip to content

chore: add missing ext-sodium in suggest #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2023
Merged

chore: add missing ext-sodium in suggest #8281

merged 2 commits into from
Dec 8, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 1, 2023

Description
Reported in #8273 (comment)

  • add missing ext-sodium

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis mentioned this pull request Dec 1, 2023
Merged
5 tasks
@kenjis kenjis force-pushed the add-ext-sodium branch 2 times, most recently from 0a65b3a to a5b3300 Compare December 1, 2023 06:12
MGatner
MGatner requested changes Dec 2, 2023
View reviewed changes
@kenjis kenjis requested a review from MGatner December 2, 2023 20:36
@kenjis kenjis merged commit a37ae72 into codeigniter4:develop Dec 8, 2023
@kenjis kenjis deleted the add-ext-sodium branch December 8, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @MGatner @paulbalandan