Skip to content

chore: update phpstan-baseline.php #8311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 9, 2023

Description
Because of PHPStan upgrade.

Error: Ignored error pattern #^Return type \(CodeIgniter\\Database\\MySQLi\\PreparedQuery\) of method CodeIgniter\\Database\\MySQLi\\PreparedQuery\:\:_prepare\(\) should be covariant with return type \(\$this\(CodeIgniter\\Database\\BasePreparedQuery\<TConnection, TStatement, TResult\>\)\) of method CodeIgniter\\Database\\BasePreparedQuery\<mysqli,mysqli_stmt,mysqli_result\>\:\:_prepare\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/MySQLi/PreparedQuery.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\Database\\OCI8\\PreparedQuery\) of method CodeIgniter\\Database\\OCI8\\PreparedQuery\:\:_prepare\(\) should be covariant with return type \(\$this\(CodeIgniter\\Database\\BasePreparedQuery\<TConnection, TStatement, TResult\>\)\) of method CodeIgniter\\Database\\BasePreparedQuery\<resource,resource,resource\>\:\:_prepare\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/PreparedQuery.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\Database\\Postgre\\PreparedQuery\) of method CodeIgniter\\Database\\Postgre\\PreparedQuery\:\:_prepare\(\) should be covariant with return type \(\$this\(CodeIgniter\\Database\\BasePreparedQuery\<TConnection, TStatement, TResult\>\)\) of method CodeIgniter\\Database\\BasePreparedQuery\<PgSql\\Connection,PgSql\\Result,PgSql\\Result\>\:\:_prepare\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Postgre/PreparedQuery.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\Database\\SQLSRV\\PreparedQuery\) of method CodeIgniter\\Database\\SQLSRV\\PreparedQuery\:\:_prepare\(\) should be covariant with return type \(\$this\(CodeIgniter\\Database\\BasePreparedQuery\<TConnection, TStatement, TResult\>\)\) of method CodeIgniter\\Database\\BasePreparedQuery\<resource,resource,resource\>\:\:_prepare\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/SQLSRV/PreparedQuery.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\Database\\SQLite3\\PreparedQuery\) of method CodeIgniter\\Database\\SQLite3\\PreparedQuery\:\:_prepare\(\) should be covariant with return type \(\$this\(CodeIgniter\\Database\\BasePreparedQuery\<TConnection, TStatement, TResult\>\)\) of method CodeIgniter\\Database\\BasePreparedQuery\<SQLite3,SQLite3Stmt,SQLite3Result\>\:\:_prepare\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/SQLite3/PreparedQuery.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\HTTP\\DownloadResponse\) of method CodeIgniter\\HTTP\\DownloadResponse\:\:noCache\(\) should be covariant with return type \(\$this\(CodeIgniter\\HTTP\\ResponseInterface\)\) of method CodeIgniter\\HTTP\\ResponseInterface\:\:noCache\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/HTTP/DownloadResponse.php was not matched in reported errors.
Error: Ignored error pattern #^Return type \(CodeIgniter\\HTTP\\DownloadResponse\) of method CodeIgniter\\HTTP\\DownloadResponse\:\:noCache\(\) should be covariant with return type \(\$this\(CodeIgniter\\HTTP\\Response\)\) of method CodeIgniter\\HTTP\\Response\:\:noCache\(\)$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/HTTP/DownloadResponse.php was not matched in reported errors.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7147604463/job/19467408417?pr=8310

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis
Copy link
Member Author

kenjis commented Dec 9, 2023

Please review first.

@kenjis kenjis merged commit 43a06ae into codeigniter4:develop Dec 9, 2023
@kenjis kenjis deleted the update-phpstan-baseline branch December 9, 2023 08:44
@kenjis
Copy link
Member Author

kenjis commented Dec 9, 2023

@paulbalandan Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants