Skip to content

test: fix path name of composer.json #8387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2023
Merged

test: fix path name of composer.json #8387

merged 1 commit into from
Dec 29, 2023

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Dec 29, 2023 •
edited by kenjis
Loading

Description
Fixes wrong clean path of composer.json in admin/ folder.
To test, just change any version constraint of a require-dev dependency in the root composer.json.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Dec 29, 2023
@kenjis kenjis merged commit c85b65c into codeigniter4:develop Dec 29, 2023
@paulbalandan paulbalandan deleted the composer-json-test branch December 30, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @michalsn