Added hyperlink to Contributing to codeigniter section #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why updating ReadMe.md file Travis is failing? |
If you click on the "Details" link next to the failing Travis job you'll see it's completely un-related to your PR. |
lonnieezell
requested changes
Nov 27, 2017
README.md
Outdated
| @@ -63,7 +63,7 @@ if you want to take the lead for one of them. | |||
|
|
|||
| We are not looking for out-of-scope contributions, only those that would be considered part of our controlled evolution! | |||
|
|
|||
| Please read the *Contributing to CodeIgniter* section in the user guide | |||
| Please read the [*Contributing to CodeIgniter*](contributing.md) section in the user guide | |||
There was a problem hiding this comment.
This link won't actually link to the file since they're not in the same folder. Please provide a full URL to the page here on GitHub, so that it will work correctly when viewing on GitHub.
There was a problem hiding this comment.
Ok will provide complete url of contributing.md
lonnieezell
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hyperlink of Contributingmd file
https://github.com/bcit-ci/CodeIgniter4/blob/develop/contributing.md to ReadMe