Skip to content

chore: enable PHPStan checkMissingIterableValueType #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 18, 2024

Description
If left false, this error will continue to increase.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On level 6 this option is default true so we can just remove that line.

If left false, this error will continue to increase.
@kenjis kenjis force-pushed the enable-phpstan-checkMissingIterableValueType branch from c05214e to 9a5d200 Compare March 18, 2024 02:33
@kenjis
Copy link
Member Author

kenjis commented Mar 18, 2024

Removed.

@kenjis kenjis merged commit 8130587 into codeigniter4:develop Mar 20, 2024
@kenjis kenjis deleted the enable-phpstan-checkMissingIterableValueType branch March 20, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants