fix: [DBForge] addForeignKey() Table prefix issue while using with database

[Kyoiory]

While adding a foreign key to any external table, it was getting miss formatted if we defined the DB prefix like db2.table_name is being formatted like prefix_db2.tablename and the query was ended up in malformed constraint error.

This fix will add prefix to the table name only.

Description
I have changed the logic of adding prefix for foreign tables and now prefix will only prepend with table name only (last index)

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

• PRs must be sent to the appropriate branch
• All git commits must be GPG-signed
• Must follow our style guide
• Be commented in the PHP source file
• Be documented in the user guide
• Be unit tested
• Pass all checks in GitHub Actions

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

[kenjis]

Why do you need to specify the table name like db2.table_name?
I don't think now CI4 supports such a name. There is no such usage in the user guide:
https://codeigniter4.github.io/CodeIgniter4/dbmgmt/forge.html#adding-foreign-keys

So I think it is just a misuse, not a bug.

[Kyoiory]

People often use external table foreign relationships. Just like in my case where i wanted to add foreign key with tablea from databasea to tableb of databaseb, and was getting it formatted like "prefix_databaseb.tableb"

[kenjis]

Okay, that makes sense.
But I'm not sure this is a bug fix or enhancement.

In any case, please fix all errors in GitHub Actions.

[kenjis]

We have a command to fix coding style.

composer cs-fix

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style

[Kyoiory]

I am not working with composer until SDLC. Right now i am at pre planning phase and only able to structure my code.

[kenjis]

Sorry, I don't get what you mean by "until SDLC".

If you don't use Composer, you cannot run PHPUnit.
How could you write test code for this PR?

In any case, we do not accept PRs without test code.
Thank you.

[Kyoiory]

Actually i ran the fixer couple of times (on standalone installation) and only change the specific 3 lines.

[datamweb]

Please make sure to update the packages first with the following command.

composer update

Then run command :

git switch patch-1

Then run

composer cs-fix

git add system/Database/Forge.php system/Database/BaseConnection.php
git commit -m "style: fix code style"
git push origin patch-1

[kenjis]

By the way, can you write test code?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

We do not accept PRs without test code.

[kenjis]

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests
added to our test suite to prove the code works.

This PR does not have the necessary test code. If you want this PR to be reviewed, please add the test code.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

If the test is not added, this PR will be closed.