Skip to content

refactor: fix property.protected errors #9517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions system/Encryption/Encryption.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
* This class determines the driver, cipher, and mode to use, and then
* initializes the appropriate encryption handler.
*
* @property-read string $digest
* @property-read string $driver
* @property-read list<string> $drivers
* @property-read string $key
*
* @see \CodeIgniter\Encryption\EncryptionTest
*/
class Encryption
Expand Down
8 changes: 7 additions & 1 deletion system/I18n/TimeDifference.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,13 @@
use IntlCalendar;

/**
* Class TimeDifference
* @property-read float|int $days
* @property-read float|int $hours
* @property-read float|int $minutes
* @property-read float|int $months
* @property-read int $seconds
* @property-read float|int $weeks
* @property-read float|int $years
*
* @see \CodeIgniter\I18n\TimeDifferenceTest
*/
Expand Down
7 changes: 1 addition & 6 deletions utils/phpstan-baseline/isset.property.neon
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 3 errors
# total 2 errors

parameters:
ignoreErrors:
Expand All @@ -11,8 +11,3 @@ parameters:
message: '#^Static property CodeIgniter\\Email\\Email\:\:\$func_overload \(bool\) in isset\(\) is not nullable\.$#'
count: 1
path: ../../system/Email/Email.php

-
message: '#^Property CodeIgniter\\I18n\\TimeDifference\:\:\$days \(int\) in isset\(\) is not nullable\.$#'
count: 1
path: ../../tests/system/I18n/TimeDifferenceTest.php
3 changes: 1 addition & 2 deletions utils/phpstan-baseline/loader.neon
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 3605 errors
# total 3589 errors
includes:
- argument.type.neon
- assign.propertyType.neon
Expand Down Expand Up @@ -31,7 +31,6 @@ includes:
- property.nonObject.neon
- property.notFound.neon
- property.phpDocType.neon
- property.protected.neon
- property.readOnlyByPhpDocAssignOutOfClass.neon
- property.readOnlyByPhpDocDefaultValue.neon
- staticMethod.notFound.neon
Expand Down
48 changes: 0 additions & 48 deletions utils/phpstan-baseline/property.protected.neon

This file was deleted.

Loading