Skip to content

refactor: import FQCNs #9520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

refactor: import FQCNs #9520

merged 1 commit into from
Apr 13, 2025

Conversation

paulbalandan
Copy link
Member

Description
Import them in use statements.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 13, 2025
@paulbalandan paulbalandan merged commit 50b3f57 into codeigniter4:develop Apr 13, 2025
49 checks passed
@paulbalandan paulbalandan deleted the import-symbols branch April 13, 2025 17:21
@neznaika0
Copy link
Contributor

The import is regulated by the cs rules. It seems they intentionally allow FQCN in the code.

@paulbalandan
Copy link
Member Author

This is caused by the import_symbols option of fully_qualified_strict_types rule to be set to false. That was a new option though so that's why is not reflected here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalandan @neznaika0 @samsonasik @ddevsr