Skip to content

refactor: fix isset.property errors #9522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

refactor: fix isset.property errors #9522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Autoloader/Autoloader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function initialize(Autoload $config, Modules $modules)
$this->files = $config->files;
}

if (isset($config->helpers)) {
if ($config->helpers !== []) {
$this->helpers = [...$this->helpers, ...$config->helpers];
}

Expand Down
5 changes: 3 additions & 2 deletions system/Email/Email.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ class Email
/**
* mbstring.func_overload flag
*
* @var bool
* @var bool|null
*/
protected static $func_overload;

Expand All @@ -403,8 +403,9 @@ class Email
public function __construct($config = null)
{
$this->initialize($config);

if (! isset(static::$func_overload)) {
static::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
static::$func_overload = extension_loaded('mbstring') && ini_get('mbstring.func_overload');
}
}

Expand Down
13 changes: 0 additions & 13 deletions utils/phpstan-baseline/isset.property.neon
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 3575 errors
# total 3573 errors
includes:
- argument.type.neon
- assign.propertyType.neon
Expand All @@ -11,7 +11,6 @@ includes:
- deadCode.unreachable.neon
- empty.notAllowed.neon
- generator.valueType.neon
- isset.property.neon
- method.alreadyNarrowedType.neon
- method.childParameterType.neon
- method.childReturnType.neon
Expand Down
Loading