refactor: fix nullCoalesce.variable errors
#9524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Apr 13, 2025
samsonasik
reviewed
Apr 13, 2025
|
The correction requires other actions. What do you think about |
warcooft
force-pushed
the
null-coalesce-variable
branch
from
e211a7d to
92ab64d
Compare
paulbalandan
changed the title
nullCoalesce.variable errors
paulbalandan
requested changes
Apr 14, 2025
rm nullCoalesce.variable.neon Update error count Restore missing nullCoalesce.variable.neon file Update loader.neon and remove obsolete nullCoalesce.variable.neon Use type checking instead of null coalescing Prevent superglobals from being changed by users chore: suppress PHPStan warning for and
warcooft
force-pushed
the
null-coalesce-variable
branch
from
15b3540 to
ee0580f
Compare
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
|
Thank you @paulbalandan |
paulbalandan
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
nullCoalesce.variableerrors. Superglobals like$_GETand$_POSTare always defined by PHP, coalescing to arrays is not required.Checklist: