Make image conv memory coalescence example more intuitive #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous arrangement used a rather devious (32, 1) group size to enforce a requirement for flipping the globalId inside the kernel. This is fine but it makes it seem like a sycl ID is row major but a sycl::buffer is col major. The exercise is now kind of reversed - we keep an intuitive work-group shape in reference.cpp but we add the (now rogue) globalId flip so that memory access isn't coalesced. The 'solution' for the coalescence exercise now is to remove the globalId flip.
|
Likewise, do we need his update for the |
|
Yeah that's a good point, we should apply these changes to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous arrangement used a rather devious (32, 1) group size to
enforce a requirement for flipping the globalId inside the
kernel. This is fine but it makes it seem like a
sycl::idis row majorbut a
sycl::bufferis col major.The exercise is now kind of reversed - we keep an intuitive work-group
shape in
reference.cppbut we add the (now rogue)globalIdflip sothat memory access isn't coalesced. The 'solution' for the coalescence
exercise now is to remove the globalId flip.