-
Notifications
You must be signed in to change notification settings - Fork 109
Merge usm buffers #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge usm buffers #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor comments.
@@ -280,65 +383,34 @@ | |||
<!--Slide 16--> | |||
<section> | |||
<div class="hbox" data-markdown> | |||
#### Access modes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fair to remove these parts since this will now be a bigger lecture, but we should move them to another section, or perhaps create a new ticket for adding this in somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still mentioning sycl::no_init
as well as the accessor access modes. These resolution cases are a little bit niche and maybe we could try and fit them into Advanced_Data_Flow? Would be an easy copy-paste and could add to this PR. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, let's do that.
If this is something that we think is suitable for syclacademy:main I can make changes to the entire repo, such as:
|
LGTM, I added a missing wait() on the slides. |
Merge USM and buffer/accessors chapter into one. Quite a long chapter - perhaps some things can be trimmed and put into other chapters. Let me know