Skip to content

Merge usm buffers #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Aug 24, 2022

Merge USM and buffer/accessors chapter into one. Quite a long chapter - perhaps some things can be trimmed and put into other chapters. Let me know

Copy link
Contributor

@AerialMantis AerialMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments.

@@ -280,65 +383,34 @@
<!--Slide 16-->
<section>
<div class="hbox" data-markdown>
#### Access modes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fair to remove these parts since this will now be a bigger lecture, but we should move them to another section, or perhaps create a new ticket for adding this in somewhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still mentioning sycl::no_init as well as the accessor access modes. These resolution cases are a little bit niche and maybe we could try and fit them into Advanced_Data_Flow? Would be an easy copy-paste and could add to this PR. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, let's do that.

@hdelan hdelan changed the base branch from cppcon22 to main August 26, 2022 08:51
@hdelan
Copy link
Contributor Author

hdelan commented Aug 26, 2022

If this is something that we think is suitable for syclacademy:main I can make changes to the entire repo, such as:

  1. Remove USM chapter (and shift other chapters down)
  2. Changing mentions of USM/buf-acc chapters in every other chapter.

@joeatodd
Copy link
Contributor

joeatodd commented Sep 7, 2022

LGTM, I added a missing wait() on the slides.

@joeatodd joeatodd merged commit bf85601 into codeplaysoftware:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants