Skip to content

Remove messy load balancing exercise #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 6 additions & 29 deletions Code_Exercises/Exercise_13_Load_Balancing/solution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,38 +26,15 @@ class vector_add_second;
// allowing computation to be split across said devices.
std::vector<sycl::device> get_two_devices() {
auto devs = sycl::device::get_devices();
if (devs.size() == 0) throw "No devices available";
if (devs.size() == 1)
return {devs[0], devs[0]};

// Choose the first non-host devices
std::sort(devs.begin(), devs.end(), [](sycl::device &d1, sycl::device &d2) {
return !d1.is_host() && d2.is_host(); });

auto host_it{std::find_if(devs.begin(), devs.end(),
[](sycl::device &d) { return d.is_host(); })};

// Don't mix Nvidia and non-Nvidia devices to avoid incompatible binary
auto nvidia_it{std::find_if(devs.begin(), devs.end(), [](sycl::device &d) {
return d.get_info<sycl::info::device::vendor>().find("NVIDIA") !=
std::string::npos;
})};
if (nvidia_it != devs.end()) {
auto nvidia_it2 =
std::find_if(nvidia_it + 1, devs.end(), [](sycl::device &d) {
return d.get_info<sycl::info::device::vendor>().find("NVIDIA") !=
std::string::npos;
});
if (nvidia_it2 != devs.end())
return {*nvidia_it, *nvidia_it2};
if (host_it != devs.end())
return {*nvidia_it, *host_it};
return {*nvidia_it, *nvidia_it};
}

auto dev_it{std::find_if(devs.begin(), devs.end(),
[](sycl::device &d) { return !d.is_host(); })};
auto dev_it2{std::find_if(dev_it + 1, devs.end(),
[](sycl::device &d) { return !d.is_host(); })};

if (dev_it2 != devs.end())
return {*dev_it, *dev_it2};
return {*host_it, *dev_it};
return {devs[0], devs[1]};
}


Expand Down