-
Notifications
You must be signed in to change notification settings - Fork 15
Fix missing syntax highlighting in proposed diff view #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,6 +215,40 @@ describe("Diff Module", function() | |
end) | ||
end) | ||
|
||
describe("Filetype Propagation", function() | ||
it("should propagate original filetype to proposed buffer", function() | ||
diff.setup({}) | ||
|
||
-- Spy on nvim_set_option_value | ||
spy.on(_G.vim.api, "nvim_set_option_value") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] After spying on Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
local mock_file = { | ||
write = function() end, | ||
close = function() end, | ||
} | ||
local old_io_open = io.open | ||
rawset(io, "open", function() | ||
return mock_file | ||
end) | ||
|
||
local result = diff._open_native_diff("/tmp/test.ts", "/tmp/test.ts", "-- new", "Propagate FT") | ||
expect(result.success).to_be_true() | ||
|
||
-- Verify spy called with filetype typescript | ||
local calls = _G.vim.api.nvim_set_option_value.calls or {} | ||
local found = false | ||
for _, c in ipairs(calls) do | ||
if c.vals[1] == "filetype" and c.vals[2] == "typescript" then | ||
found = true | ||
break | ||
end | ||
end | ||
expect(found).to_be_true() | ||
|
||
rawset(io, "open", old_io_open) | ||
end) | ||
end) | ||
|
||
describe("Open Diff Function", function() | ||
it("should use native provider", function() | ||
diff.setup({}) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider extracting the
simple_map
table to a module-level constant so it isn’t recreated on every call, improving performance and clarity.Copilot uses AI. Check for mistakes.