Skip to content

chore(go.mod): update github.com/fergusstrange/embedded-postgres to v1.24.0 #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Aug 29, 2023

While taking a look at our embedded database configuration, I also noticed that github.com/fergusstrange/embedded-postgres includes the cache path fix: fergusstrange/embedded-postgres#120

This was the main reason to use our fork, AFAICT.

The updated embedded-postgres has new options for specifying postgres settings on start, e.g.

embeddedpostgres.DefaultConfig().
	StartParameters(map[string]string{
		// Defaults, we could adjust depending on memory limits.
		"max_connections": "100",
		"work_mem":        "4MB",
		"shared_buffers":  "128MB",
	})

These could prove useful in the future.

@mafredri mafredri self-assigned this Aug 29, 2023
@mafredri mafredri requested a review from kylecarbs August 29, 2023 12:10
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mafredri mafredri merged commit 605d2b2 into main Aug 29, 2023
@mafredri mafredri deleted the mafredri/chore-update-embedded-postgres branch August 29, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants