feat(local-windows-rdp): local Windows RDP using coder desktop #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utilizing coder Desktop
…th usage examples and requirements
…n and custom credential checks
… features, and requirements for RDP access
matifali
reviewed
May 28, 2025
| icon: ../../../../.icons/desktop.svg | ||
| maintainer_github: coder | ||
| verified: false | ||
| tags: [rdp, windows, desktop, remote] |
There was a problem hiding this comment.
Suggested change
| tags: [rdp, windows, desktop, remote] | |
| coder_desktop: true | |
| supported_os: [windows] | |
| tags: [rdp, windows, desktop, remote] |
See coder/registry-server#204 and coder/registry-server#199. We still need to implement these in the backend.
@Parkreiner, is it fine if we add these extra metadata entries even though they are yet handled in the registry server?
| ## Requirements | ||
|
|
||
| - **Coder Desktop**: Must be installed on the client machine ([Download here](https://github.com/coder/coder/releases)) | ||
| - **Windows Workspace**: The target workspace must be running Windows |
There was a problem hiding this comment.
I hope we can handle this using metadata, a badge, and a filter in the frontend. coder/registry-server#199
There was a problem hiding this comment.
should I leave the coder desktop requirement since it is not supported with the badges at the moment?
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
…ent_name variable, Refine examples for clarity
…tests and adjust test cases accordingly
|
@matifali I have commit the resolutions to your issues. I will go ahead and test these in each environment so we can verify that it works across the board before releasing. |
matifali
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces coder module: local-windows-rdp
Testing