fix: use image of container in MigratorSpec #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, the operator would inject an waiter container that would poll for the image of the first container in the target Pod rather than the image of the specified container. This is surprising behaviour and also potentially problematic when combined with Istio's `holdApplicationUntilProxyStart` functionality, which injects the Istio sidecar at the beginning of the list of containers. This commit ensures the operator uses the container specified in the MigratorSpec, if supplied and present. If the target container name is specified and not present, it falls back to using the image from the first container in the Pod (the previous behaviour). If the target container name is not present, it also uses the previous behaviour.
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the operator would inject an waiter container
that would poll for the image of the first container in the target Pod
rather than the image of the specified container. This is surprising
behaviour and also potentially problematic when combined with Istio's
holdApplicationUntilProxyStartfunctionality, which injects the Istiosidecar at the beginning of the list of containers.
This commit ensures the operator uses the container specified in the
MigratorSpec, if supplied and present. If the target container name is
specified and not present, it falls back to using the image from the
first container in the Pod (the previous behaviour). If the target
container name is not present, it also uses the previous behaviour.