fix: make findOwners handle custom types better #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change stops the controller from bubbling up an error when it encounters a Kind that is has not registered in its scheme or an object that it does not have access to. In these situations, the controller will now stop climbing the ownership tree instead. The new behaviour is desireable when an unsupported type (such as one from a company's in-house operator) is marked as the controller of the resource that controls the pods themselves.
|
Hah, "note for the future" indeed :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stops the controller from bubbling up an error when it
encounters a Kind that is has not registered in its scheme or an object
that it does not have access to. In these situations, the controller
will now stop climbing the ownership tree instead.
The new behaviour is desireable when an unsupported type (such as one
from a company's in-house operator) is marked as the controller of the
resource that controls the pods themselves.