Skip to content

Support Django 4.1, Python 3.10, and fix Selenium tests #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

adamchainz
Copy link

@adamchainz adamchainz commented Sep 9, 2022

  1. Add Django 4.1 to the test matrix
  2. Add Python 3.10 to the test matrix
  3. Deal with some deprecation warnings from running the tests on Django 4.0+
  4. Update Selenium method calls for removals in Selenium 4.3.0 of find_element[s]_by_* methods, to the new find_element[s] method with By argument (docs).

@adamchainz adamchainz changed the title Support Django 4.1 Support Django 4.1, Python 3.10, and fix Selenium tests Sep 9, 2022
@adamchainz
Copy link
Author

I managed to run the tests locally with the latest Chrome + chromedriver, pending approval to run on GitHub Actions.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #154 (8c09928) into master (68a87ba) will decrease coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   99.60%   98.86%   -0.75%     
==========================================
  Files           7        7              
  Lines         254      264      +10     
==========================================
+ Hits          253      261       +8     
- Misses          1        3       +2     
Impacted Files Coverage Δ
django_select2/__init__.py 66.66% <0.00%> (-33.34%) ⬇️
django_select2/forms.py 99.47% <0.00%> (-0.53%) ⬇️
django_select2/conf.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codingjoe codingjoe merged commit a5aafd7 into codingjoe:master Sep 9, 2022
@codingjoe
Copy link
Owner

Thanks, @adamchainz, appreciate the help 👍
I'll invest some time to update some other things on the CI suite today. I'll ship a new release before the weekend 😃

@adamchainz adamchainz deleted the django_4.1 branch September 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants