Skip to content

Allow to mark JSON properties & XML nodes as optional #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 2, 2017
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ $matcher->getError(); // returns null or error message
* ``inArray($value)``
* ``oneOf(...$expanders)`` - example usage ``"@[email protected](contains('foo'), contains('bar'), contains('baz'))"``
* ``matchRegex($regex)`` - example usage ``"@[email protected]('/^lorem.+/')"``
* ``optional()`` - work's only with ``ArrayMatcher``, ``JsonMatcher`` and ``XmlMatcher``

##Example usage

Expand Down Expand Up @@ -237,7 +238,8 @@ $matcher->match(
'id' => 1,
'firstName' => 'Norbert',
'lastName' => 'Orzechowicz',
'roles' => array('ROLE_USER')
'roles' => array('ROLE_USER'),
'position' => 'Developer',
),
array(
'id' => 2,
Expand All @@ -261,7 +263,8 @@ $matcher->match(
'id' => '@[email protected](0)',
'firstName' => '@string@',
'lastName' => 'Orzechowicz',
'roles' => '@array@'
'roles' => '@array@',
'position' => '@[email protected]()'
),
array(
'id' => '@integer@',
Expand Down Expand Up @@ -303,7 +306,8 @@ $matcher->match(
"firstName": @string@,
"lastName": @string@,
"created": "@[email protected]()",
"roles": @array@
"roles": @array@,
"posiiton": "@[email protected]()"
}
]
}'
Expand Down Expand Up @@ -347,6 +351,7 @@ XML
<m:GetStockPrice>
<m:StockName>@string@</m:StockName>
<m:StockValue>@string@</m:StockValue>
<m:StockQty>@[email protected]()</m:StockQty>
</m:GetStockPrice>
</soap:Body>

Expand Down
32 changes: 30 additions & 2 deletions src/Matcher/ArrayMatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Coduo\PHPMatcher\Matcher;

use Coduo\PHPMatcher\Exception\Exception;
use Coduo\PHPMatcher\Parser;
use Coduo\ToString\StringConverter;
use Symfony\Component\PropertyAccess\PropertyAccess;
Expand Down Expand Up @@ -153,19 +154,46 @@ function ($item) use ($skipPattern) {
}
);

$notExistingKeys = array_diff_key($pattern, $values);

$notExistingKeys = $this->findNotExistingKeys($pattern, $values);
if (count($notExistingKeys) > 0) {
$keyNames = array_keys($notExistingKeys);
$path = $this->formatFullPath($parentPath, $this->formatAccessPath($keyNames[0]));
$this->setMissingElementInError('value', $path);

return false;
}
}

return true;
}

/**
* Finds not existing keys
* Excludes keys with pattern which includes Optional Expander
*
* @param $pattern
* @param $values
* @return array
*/
private function findNotExistingKeys($pattern, $values)
{
$notExistingKeys = array_diff_key($pattern, $values);

return array_filter($notExistingKeys, function ($pattern) use ($values) {
if (is_array($pattern)) {
return !$this->match($values, $pattern);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@norzechowicz I'm not pretty sure that we must check if values match to pattern because it already hasn't array_diff_key($pattern, $values) and also because OptionalExpander works only with top level match

}

try {
$typePattern = $this->parser->parse($pattern);
} catch (Exception $e) {
return true;
}

return !$typePattern->hasExpander('optional');
});
}

/**
* @param $value
* @param $pattern
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/Contains.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class Contains implements PatternExpander
{
const NAME = 'contains';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/Count.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class Count implements PatternExpander
{
const NAME = 'count';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/EndsWith.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class EndsWith implements PatternExpander
{
const NAME = 'endsWith';

/**
* @var
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/GreaterThan.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class GreaterThan implements PatternExpander
{
const NAME = 'greaterThan';

/**
* @var
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/InArray.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class InArray implements PatternExpander
{
const NAME = 'inArray';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/IsDateTime.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class IsDateTime implements PatternExpander
{
const NAME = 'isDateTime';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/IsEmail.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class IsEmail implements PatternExpander
{
const NAME = 'isEmail';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/IsEmpty.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class IsEmpty implements PatternExpander
{
const NAME = 'isEmpty';

private $error;

/**
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/IsNotEmpty.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class IsNotEmpty implements PatternExpander
{
const NAME = 'isNotEmpty';

private $error;

/**
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/IsUrl.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class IsUrl implements PatternExpander
{
const NAME = 'isUrl';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/LowerThan.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class LowerThan implements PatternExpander
{
const NAME = 'lowerThan';

/**
* @var
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/MatchRegex.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class MatchRegex implements PatternExpander
{
const NAME = 'matchRegex';

/**
* @var null|string
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/OneOf.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class OneOf implements PatternExpander
{
const NAME = 'oneOf';

/**
* @var PatternExpander[]
*/
Expand Down
26 changes: 26 additions & 0 deletions src/Matcher/Pattern/Expander/Optional.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?php

namespace Coduo\PHPMatcher\Matcher\Pattern\Expander;

use Coduo\PHPMatcher\Matcher\Pattern\PatternExpander;

final class Optional implements PatternExpander
{
const NAME = 'optional';

/**
* {@inheritdoc}
*/
public function match($value)
{
return true;
}

/**
* {@inheritdoc}
*/
public function getError()
{
return null;
}
}
2 changes: 2 additions & 0 deletions src/Matcher/Pattern/Expander/StartsWith.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

final class StartsWith implements PatternExpander
{
const NAME = 'startsWith';

/**
* @var
*/
Expand Down
9 changes: 9 additions & 0 deletions src/Matcher/Pattern/Pattern.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,13 @@ public function matchExpanders($value);
* @return null|string
*/
public function getError();

/**
* Checks whether a Pattern has added Expander.
*
* @param string $expanderName The name of the expander
*
* @return bool true if the specified pattern has expander, false otherwise
*/
public function hasExpander(string $expanderName);
}
16 changes: 15 additions & 1 deletion src/Matcher/Pattern/TypePattern.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,24 @@ public function matchExpanders($value)
}

/**
* @return null|string
* {@inheritdoc}
*/
public function getError()
{
return $this->error;
}

/**
* {@inheritdoc}
*/
public function hasExpander(string $expanderName)
{
foreach ($this->expanders as $expander) {
if ($expander::NAME === $expanderName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the problem, interface can't guarantee that Expander will have NAME constant. Please add is($name) method as I suggested in my previous comment

return true;
}
}

return false;
}
}
43 changes: 22 additions & 21 deletions src/Parser/ExpanderInitializer.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,36 @@

namespace Coduo\PHPMatcher\Parser;

use Coduo\PHPMatcher\AST\Expander;
use Coduo\PHPMatcher\AST\Expander as ExpanderNode;
use Coduo\PHPMatcher\Exception\InvalidArgumentException;
use Coduo\PHPMatcher\Exception\InvalidExpanderTypeException;
use Coduo\PHPMatcher\Exception\UnknownExpanderClassException;
use Coduo\PHPMatcher\Exception\UnknownExpanderException;
use Coduo\PHPMatcher\Matcher\Pattern\PatternExpander;
use Coduo\PHPMatcher\Matcher\Pattern\Expander;

final class ExpanderInitializer
{
/**
* @var array
*/
private $expanderDefinitions = array(
"startsWith" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\StartsWith",
"endsWith" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\EndsWith",
"isNotEmpty" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\IsNotEmpty",
"isEmpty" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\IsEmpty",
"isDateTime" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\IsDateTime",
"isEmail" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\IsEmail",
"isUrl" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\IsUrl",
"lowerThan" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\LowerThan",
"greaterThan" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\GreaterThan",
"inArray" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\InArray",
"count" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\Count",
"contains" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\Contains",
"matchRegex" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\MatchRegex",

"oneOf" => "Coduo\\PHPMatcher\\Matcher\\Pattern\\Expander\\OneOf"
);
private $expanderDefinitions = [
Expander\Contains::NAME => Expander\Contains::class,
Expander\Count::NAME => Expander\Count::class,
Expander\EndsWith::NAME => Expander\EndsWith::class,
Expander\GreaterThan::NAME => Expander\GreaterThan::class,
Expander\InArray::NAME => Expander\InArray::class,
Expander\IsDateTime::NAME => Expander\IsDateTime::class,
Expander\IsEmail::NAME => Expander\IsEmail::class,
Expander\IsEmpty::NAME => Expander\IsEmpty::class,
Expander\IsNotEmpty::NAME => Expander\IsNotEmpty::class,
Expander\IsUrl::NAME => Expander\IsUrl::class,
Expander\LowerThan::NAME => Expander\LowerThan::class,
Expander\MatchRegex::NAME => Expander\MatchRegex::class,
Expander\OneOf::NAME => Expander\OneOf::class,
Expander\Optional::NAME => Expander\Optional::class,
Expander\StartsWith::NAME => Expander\StartsWith::class,
];

/**
* @param string $expanderName
Expand Down Expand Up @@ -70,12 +71,12 @@ public function getExpanderDefinition($expanderName)
}

/**
* @param Expander $expanderNode
* @param ExpanderNode $expanderNode
* @throws InvalidExpanderTypeException
* @throws UnknownExpanderException
* @return PatternExpander
*/
public function initialize(Expander $expanderNode)
public function initialize(ExpanderNode $expanderNode)
{
if (!array_key_exists($expanderNode->getName(), $this->expanderDefinitions)) {
throw new UnknownExpanderException(sprintf("Unknown expander \"%s\"", $expanderNode->getName()));
Expand All @@ -86,7 +87,7 @@ public function initialize(Expander $expanderNode)
if ($expanderNode->hasArguments()) {
$arguments = array();
foreach ($expanderNode->getArguments() as $argument) {
$arguments[] = ($argument instanceof Expander)
$arguments[] = ($argument instanceof ExpanderNode)
? $this->initialize($argument)
: $argument;
}
Expand Down
Loading