Matcher modifiers #132
Closed
Matcher modifiers #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszsip
force-pushed
the
feature/modifiers
branch
2 times, most recently
from
1e689db to
ac4a957
Compare
|
Const visibility is probably not a feature we need, I will restore php 7.0 compat later. |
norberttech
reviewed
May 7, 2018
.travis.yml
Outdated
| @@ -8,7 +8,7 @@ cache: | |||
|
|
|||
| matrix: | |||
| include: | |||
| - php: 7.0 | |||
| - php: 7.1 | |||
norberttech
reviewed
May 7, 2018
composer.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.0.0", | |||
| "php": ">=7.1.0", | |||
|
@kejwmen + for this feature, maybe you can revert php version asked by @norzechowicz to merge this PR? |
|
@vitalyiegorov |
mateuszsip
force-pushed
the
feature/modifiers
branch
from
ac4a957 to
cc097b0
Compare
|
Restored php 7.0 compat, ScalarMatcher supports Could you take a look at my code, maybe we should write some additional integration tests? |
|
@norzechowicz could you take a look here? |
|
What I don't like with this approach is that if I want to allow extra keys only in specific place inside nested array, I can't do this with modifier, because modifiers work on whole pattern. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces idea described here with two modifiers:
CaseInsensitiveandIgnoreExtraKeys.#126 is included in this PR, I will rebase after it is merged.