Missing type in RegexConverter #46
Conversation
We have used type null, and after update to 1.1.4 we get an Exception.
| @@ -19,6 +19,8 @@ public function toRegex(TypePattern $type) | |||
| return "(\\-?[0-9]*)"; | |||
| case 'double': | |||
| return "(\\-?[0-9]*[\\.|\\,][0-9]*)"; | |||
| case 'null': | |||
| return "(null|NULL)"; | |||
There was a problem hiding this comment.
I guess it have no sense to match "lorem ipsum null" against pattern "lorem ipsum @null@" in texts, maybe instead of supporting @null@ type matcher we could handle UnknownTypeException in TextMatcher and fail matching when this exception is throwed with error message that "@null@ type matcher is not supported in text matching".
What do you think @rklak ?
There was a problem hiding this comment.
It's good, but with this change project was switched from 1.1.x to 1.1.4 - I think it was too big refactor to switch only the last number in version. It should be in 1.2 so when we've updated in project this library with 1.1.* format in our composer now we got an Exception.
Null is useless, thats true, so we will remove it from our mocks... but as I said - too big change for the last number :)
You probably now this: http://semver.org/
3. PATCH version when you make backwards-compatible bug fixes.
|
As adding |
We have used type null, and after update to 1.1.4 we get an Exception.