Fix compatibility to PHPUnit 9 #464
Conversation
composer.json
Outdated
| "conflict": { | ||
| "phpunit/phpunit": ">=11.0" | ||
| }, |
There was a problem hiding this comment.
Modifying tools/ seems more natural.
php-matcher/tools/composer.json
Line 5 in d2d7b1d
"phpunit/phpunit": "^10.0 <11.0",
There was a problem hiding this comment.
Actually "phpunit/phpunit": "~9 || ~10" in tools should work even better but I'm starting to think that we might want to move PHPUnit into main composer.json require-dev section since phpmatcher is proving an integration with it. If PHPUnit would be added to composer.json instead of tools, test workflows would detect that since they should be expected at lowest/current/latest dependencies.
There was a problem hiding this comment.
Modifying tools / seems more natural.
The require-dev and tools part is not keep in mind for project using the php-matcher and so will fail like in #463 and we recommend to this and not just set PHPUnit now to ^10 because else all will get failing version 6.0.12 on phpunit 9, so at current case I recommend to release a PHPUnit 9 compatible version, before requiring only PHPUnit 10.
I did go with conflict this is the only way of handling optionalDependencies just added it to avoid that incompatible version is installed in future. The only way would be move it as hard dependencies. Which is fine from my side, but I understand that maybe somebody don't want that PHPUnit is installed when using the package, so the only solution beside conflict is set the supported version in require section.
There was a problem hiding this comment.
Lets move phpunit to require-dev in main composer.json - this will not make composer to install PHPUnit for everyone who is using phpmatcher, but it will let test suite to run against different PHPUnit versions.
https://phpunit.de/supported-versions.html
According to this page I think matcher 6.x should support ~8 || ~9 || ~10 versions of PHPUnit.
There was a problem hiding this comment.
We still require the conflict part as described above the require-dev does not disallow that false version of php-matcher is installed. Else we run into same problems when PHPUnit 11 is released.
Lets say we remove the support for PHPUnit 8 and 9 in an upcoming release 6.1 release. With the conflict moved then to <10, >=11 users using PHPUnit 8 and 9 will only get the new version when they are also upgrading to PHPUnit 10 in there project. With the conflict they stay on the version supporting there related PHPUnit version. Without the conflict they will get incopatible coduo php matcher version which maybe doesn't support there PHPUnit version. This is because composer does only keep require and conflict in mind to find correct package version, the require-dev only for the package manager not the one using the package.
There was a problem hiding this comment.
@norberttech can you help with generating the composer.lock files not sure how to handle this now.
There was a problem hiding this comment.
yeah, that is indeed weird, could you maybe try to remove composer.lock and run composer update? If that won't work I will take a look at what's going on there.
There was a problem hiding this comment.
which php version I should use to update the composer.lock?
I pushed now the locks with PHP 8.1.16
There was a problem hiding this comment.
8.1 should be fine as its the lowest supported version
There was a problem hiding this comment.
I think now all should be fine.
|
thank you @alexander-schranz!! |
alexander-schranz
deleted the
bugfix/php-matcher-phpunit-10-9-compatibility
branch
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
fixes #463
I'm not sure if there are more
parameter typesadded in the pull request breaking this atleast this changes fixes the problem in my installation.Atleast not sure if we need add also a bc layer here: