Skip to content

fix baselines #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix baselines #31

merged 1 commit into from
Sep 17, 2024

Conversation

nanjiangwill
Copy link
Collaborator

quick fix baseline running issue

wenting-zhao
wenting-zhao reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@wenting-zhao wenting-zhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing cwd during runtime like os.chdir(repo_path) can cause lots of errors. we need a way to handle this better.

Edited: I think context manager will be great for this. will first merge this commit and start my reorg.

@wenting-zhao wenting-zhao merged commit 02da7e9 into main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenting-zhao wenting-zhao wenting-zhao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanjiangwill @wenting-zhao