-
-
Notifications
You must be signed in to change notification settings - Fork 19
Regenerate parsers with schema graph property #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
57c8b03
to
ccda963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you modify this to temporarily install schema salad from that other PR so that the import works correctly?
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 22.42% 23.58% +1.15%
==========================================
Files 27 27
Lines 20629 20719 +90
Branches 5762 5777 +15
==========================================
+ Hits 4627 4886 +259
+ Misses 14998 14794 -204
- Partials 1004 1039 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Can we get some tests showing off the new functionality?
Some unit tests have been added in the schema_salad original PR. Which kind of tests would you like to have here? |
Yeah, loading of a particular object from a CWL $graph file |
This PR is about the |
Mea culpa!
Yes, please :-) |
I added just one test. I think it is enough here as this PR basically just imports an external modification which is widely tested in the |
51e8ace
to
aa85db1
Compare
aa85db1
to
9d87144
Compare
9d87144
to
8561612
Compare
236490b
to
59e73fc
Compare
This PR regenerates parser to apply updates introduced in this schema_salad PR.