Allow disabling matching the container user to the running user #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @denis-yuen Does this PR fix it for @brainstorm et al. or is the gid sticky bit trick also needed? |
|
So far it does! I'm running the pipeline from dockstore/dockstore#475 and it does not seem to crash as immediately as it did before on the cwltool step. +1 on merging this I would say. |
|
No sticky bits or other additions needed AFAICT right now... so ++1 for merge, imho. |
|
Thanks, all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running into an issue where cwltool sets the uid to match the running user overriding the
USERcommand https://docs.docker.com/engine/reference/builder/#/userThis pull request proposes an option to disable this setting.
This is further documented at dockstore/dockstore#475