Skip to content

[MRG] turn on Python 3 on travis CI #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 17, 2017
Merged

[MRG] turn on Python 3 on travis CI #464

merged 9 commits into from
Jul 17, 2017

Conversation

manu-chroma
Copy link
Member

No description provided.

@manu-chroma
Copy link
Member Author

for this to work, we'll need to make a new schema_salad release which uses avro-cwl for Python 3

@manu-chroma
Copy link
Member Author

this one looks baked. @mr-c can you review?

@manu-chroma
Copy link
Member Author

also, how to go about running conformance tests for python 3 in jenkins?

@mr-c
Copy link
Member

mr-c commented Jul 13, 2017

@manu-chroma #465 :-)

@manu-chroma manu-chroma force-pushed the unicode_literal_usage branch from a431179 to 6abb399 Compare July 13, 2017 14:47
kapilkd13 pushed a commit to kapilkd13/cwltool that referenced this pull request Jul 14, 2017
0f28896 Merge pull request common-workflow-language#408 from kapilkd13/master
18fc8d6 Merge branch 'master' into master
d71b2f7 Merge pull request common-workflow-language#467 from kapilkd13/inlineJS-conformance
1f5f0de Update conformance_test_v1.0.yaml
8abc3f7 Merge pull request common-workflow-language#472 from common-workflow-language/no-draft-links
7134321 remove links to pre-v1.0 from homepage
2a88775 Merge pull request common-workflow-language#471 from common-workflow-language/changelong-tweak
0e0cb4b clarify that these change descriptions are specific to each of the standards
da56971 added conformance test for InlineJavascriptRequirement
485be33 Merge pull request common-workflow-language#465 from common-workflow-language/video_link
d874786 Add preview & link to intro video
397769d Merge pull request common-workflow-language#463 from common-workflow-language/hmenager-patch-1
cab882c version links
ca21bdf moar
84bd265 Update cli-description-languages-comparison.md
0cd5307 Merge pull request common-workflow-language#464 from common-workflow-language/bd2k
1cd58d3 Update cli-description-languages-comparison.md
4834980 Add BD2K as a participating organization
80e52b5 Update cli-description-languages-comparison.md
4f1fcd5 Update cli-description-languages-comparison.md
145bd0b Update cli-description-languages-comparison.md
c9ed818 Update cli-description-languages-comparison.md
1da94c2 Update cli-description-languages-comparison.md
1ff1819 Update cli-description-languages-comparison.md
24d782b Update cli-description-languages-comparison.md
e793622 Create cli-description-languages-comparison.md
2625c13 adding conformance test: Testing warning instead of error when default path is not present
52d9fcb changes to enable nolinkcheck in case of default field, related to cwltool issue #2

git-subtree-dir: cwltool/schemas
git-subtree-split: 0f28896
@manu-chroma
Copy link
Member Author

@mr-c should we merged this one before @kapilkd13 windows branch or after that one?

I might iterate some of the mypy annotations over time but this one can be merged for the time being.

@mr-c
Copy link
Member

mr-c commented Jul 16, 2017

I'm happy to merge whoever is ready first. This looks ready to me -- what do you think?

@manu-chroma manu-chroma changed the title [WIP] turn on Python 3 on travis CI [MRG] turn on Python 3 on travis CI Jul 16, 2017
@manu-chroma
Copy link
Member Author

@mr-c, I can make separate PR for any further improvements. Since this one has lesser number of changes, we can get this one merged first.

@mr-c mr-c merged commit 7d22590 into master Jul 17, 2017
@mr-c mr-c deleted the unicode_literal_usage branch July 17, 2017 08:10
@manu-chroma
Copy link
Member Author

FWIW, I've created this PR on avro repository and provided brief description for doing the same: apache/avro#235

As discussed before, using something like this failed because autotranslate anyways tried to convert all the blocks and failed.

if sys.version_info.major >= 3:
   # do something
else:
    # something else

tetron pushed a commit that referenced this pull request Jul 23, 2017
Add BD2K as a participating organization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants