Do not strip newline character for files created in InitWorkDir #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you! Is there a CWL conformance test for this yet? |
|
There is no specific guidance in the specification on this matter, so I put it into unit tests. |
|
The unit tests are great, please keep them :-) The specification is explicitly built upon YAML so a conformance test that confirms this would be very appropriate. |
anton-khodak
force-pushed
the
whitespace-iwdr
branch
2 times, most recently
from
60d5eb5 to
4bf741f
Compare
|
I confirm that this passes common-workflow-language/common-workflow-language#624 |
mr-c
approved these changes
Feb 24, 2018
|
Jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #247