Skip to content

add convenient entry point for cwltool #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2016
Merged

add convenient entry point for cwltool #66

merged 2 commits into from
Apr 22, 2016

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Apr 17, 2016

@tetron I would suggest using this (cwltool.py) instead of cwltool/main.py to solve the issues Curoverse was having since the move to relative imports.

As a reminder, here is the other workaround: setup.py install or setup.py develop and use the cwltool that gets install to the appropriate bin/ directory.

@prismofeverything
Copy link
Contributor

What was the motivation for relative imports? It breaks being able to run anything unless you are running inside the package. What is the benefit side of this tradeoff?

@mr-c
Copy link
Member Author

mr-c commented Apr 22, 2016

Hello @prismofeverything,

Relative imports are required for Python 3 compatibility, and the use of any Python 3 based tools, such as the MyPy static type checker

This PR fixes the ability to run cwltool without otherwise installing or turning on develop mode. I'm going to go ahead and merge this as I see no downsides.

Is there something I missed?

@mr-c mr-c merged commit 2c1731f into master Apr 22, 2016
@mr-c mr-c deleted the fix-relimport branch April 22, 2016 08:47
@prismofeverything
Copy link
Contributor

Ah, thanks for explaining! I forgot python 3 even existed. Yes, with your addition things run again, thanks : )

@mr-c
Copy link
Member Author

mr-c commented Apr 22, 2016

Glad to hear everything is working :-) Thank you for reminding me that I needed to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants