Add Qt5 support #38
Closed
Add Qt5 support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonQt_QT_VERSION cmake option is added ("4" or "5"). If "5",
PythonQt_Wrap_QtXYZ use a XYZ with the same Qt5 casing, if "4" it is lower
case, e.g. PythonQt_Wrap_QtWebKit vs PythonQt_Wrap_Qtwebkit
To be done:
* Rebase Qt5 support on PythonQt trunk (some changes in this commit
(e.g. in PythonQt.cpp) might not be due to a Qt5 support)
* Fix XmlPatterns
* Split generated_cpp folders regarding to Qt modules.
* Remove findCharOffset() and use QByteArray methods instead
* Bonus: Factorize method signature processings
* Fix warning:
src/PythonQtConversion.cpp: In static member function ‘static QVariant PythonQtConv::PyObjToQVariant(PyObject*, int)’:
src/PythonQtConversion.cpp:1044:27: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]
Based on Melven Zöllner work (
http://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/)
|
Created this PR so that it can be referenced in commit message and issue. |
jcfr
added a commit
to jcfr/PythonQt
that referenced
this pull request
Feb 18, 2016
Based on work from the following individual: * Melven Röhrig-Zöllner (https://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/) * Julien Finet (@finetjul): See commontk#38) * Arnaud Barre (@Alzathar):See commontk#15 * Eric Heim (@eric-h):See commontk#36
mwoehlke-kitware
pushed a commit
to mwoehlke-kitware/PythonQt
that referenced
this pull request
May 23, 2016
Based on work from the following individual: * Melven Röhrig-Zöllner (https://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/) * Julien Finet (@finetjul): See commontk#38) * Arnaud Barre (@Alzathar):See commontk#15 * Eric Heim (@eric-h):See commontk#36
jamesobutler
pushed a commit
to jamesobutler/PythonQt
that referenced
this pull request
Dec 12, 2023
Based on work from the following individual: * Melven Röhrig-Zöllner (https://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/) * Julien Finet (@finetjul): See commontk#38) * Arnaud Barre (@Alzathar):See commontk#15 * Eric Heim (@eric-h):See commontk#36
jamesobutler
pushed a commit
to jamesobutler/PythonQt
that referenced
this pull request
Dec 13, 2023
Based on work from the following individual: * Melven Röhrig-Zöllner (https://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/) * Julien Finet (@finetjul): See commontk#38) * Arnaud Barre (@Alzathar):See commontk#15 * Eric Heim (@eric-h):See commontk#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PythonQt_QT_VERSION cmake option is added ("4" or "5"). If "5",
PythonQt_Wrap_QtXYZ use a XYZ with the same Qt5 casing, if "4" it is lower
case, e.g. PythonQt_Wrap_QtWebKit vs PythonQt_Wrap_Qtwebkit
To be done:
(e.g. in PythonQt.cpp) might not be due to a Qt5 support)
src/PythonQtConversion.cpp: In static member function ‘static QVariant PythonQtConv::PyObjToQVariant(PyObject_, int)’:
src/PythonQtConversion.cpp:1044:27: warning: deprecated conversion from string constant to ‘char_’ [-Wwrite-strings]
Based on Melven Zöllner work (
http://sourceforge.net/p/pythonqt/discussion/631392/thread/5f20c176/)