Skip to content

Pin nlohmann_json to 3.12.0 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

The latest release of xeus got released, and requires nlohmann_json to be 3.12.0 . Until this PR is in the ci will fail
(see https://github.com/compiler-research/xeus-cpp/actions/runs/14604191183/job/40969335106#step:5:97).

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Remove pin on nlohmann_json Pin xeus to 5.2.0 Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (4e44614) to head (75d9476).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files           9        9           
  Lines        3650     3650           
=======================================
  Hits         2784     2784           
  Misses        866      866           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton changed the title Pin xeus to 5.2.0 Remove pin on nlohmann_json Apr 23, 2025
@anutosh491
Copy link
Collaborator

Please make the same changes you made on xeus-cpp's side here too

@mcbarton mcbarton changed the title Remove pin on nlohmann_json Pin nlohmann_json to 3.12.0 Apr 23, 2025
@mcbarton
Copy link
Collaborator Author

Please make the same changes you made on xeus-cpp's side here too

Done

@mcbarton mcbarton requested a review from anutosh491 April 23, 2025 12:47
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving feel free to merge once CI passes

check if xeus is 5.2.1 , xeus-lite is 3.1.0 too

@mcbarton mcbarton merged commit 5c1e27a into compiler-research:main Apr 23, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants