Add support for array of objects in Construct/Destruct #587

aaronj0 · 2025-05-21T15:37:20Z

No description provided.

codecov · 2025-05-21T16:00:12Z

Codecov Report

Attention: Patch coverage is 87.91209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (7bb23b9) to head (cb1a9bc).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/CppInterOp/CppInterOp.cpp	85.13%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   77.96%   78.47%   +0.51%     
==========================================
  Files           9        9              
  Lines        3767     3815      +48     
==========================================
+ Hits         2937     2994      +57     
+ Misses        830      821       -9

Files with missing lines	Coverage Δ
include/CppInterOp/CppInterOp.h	`100.00% <100.00%> (ø)`
lib/CppInterOp/CXCppInterOp.cpp	`48.86% <100.00%> (ø)`
lib/CppInterOp/CppInterOp.cpp	`86.25% <85.13%> (+0.68%)`	⬆️

Files with missing lines	Coverage Δ
include/CppInterOp/CppInterOp.h	`100.00% <100.00%> (ø)`
lib/CppInterOp/CXCppInterOp.cpp	`48.86% <100.00%> (ø)`
lib/CppInterOp/CppInterOp.cpp	`86.25% <85.13%> (+0.68%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 22. Check the log or trigger a new build to see more.

github-actions · 2025-05-21T16:53:45Z

include/clang/Interpreter/CppInterOp.h

      // Forward if we intended to call a dtor with only 1 parameter.
      if (m_Kind == kDestructorCall && result && !args.m_Args)
-        return InvokeDestructor(result, /*nary=*/0UL, /*withFree=*/true);
+        return InvokeDestructor(result, nary, /*withFree=*/true);


warning: return statement within a void function should not have a specified return value [readability-avoid-return-with-void-value]

Suggested change

return InvokeDestructor(result, nary, /*withFree=*/true);

{ InvokeDestructor(result, nary, /*withFree=*/true); return;

}

github-actions · 2025-05-21T16:53:45Z

include/clang/Interpreter/CppInterOp.h


 #ifndef NDEBUG
      assert(AreArgumentsValid(result, args, self) && "Invalid args!");
      ReportInvokeStart(result, args, self);
 #endif // NDEBUG
-      m_GenericCall(self, args.m_ArgSize, args.m_Args, result);
+      m_GenericCall(self, args.m_ArgSize, args.m_Args, result, nary);


warning: do not access members of unions; use (boost::)variant instead [cppcoreguidelines-pro-type-union-access]

m_GenericCall(self, args.m_ArgSize, args.m_Args, result, nary); ^

github-actions · 2025-05-21T16:53:45Z

include/clang/Interpreter/CppInterOp.h


 #ifndef NDEBUG
      assert(AreArgumentsValid(result, args, self) && "Invalid args!");
      ReportInvokeStart(result, args, self);
 #endif // NDEBUG
-      m_GenericCall(self, args.m_ArgSize, args.m_Args, result);
+      m_GenericCall(self, args.m_ArgSize, args.m_Args, result, nary);


warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

m_GenericCall(self, args.m_ArgSize, args.m_Args, result, nary); ^

github-actions · 2025-05-21T16:53:45Z

lib/Interpreter/CppInterOp.cpp

-  TCppObject_t Allocate(TCppScope_t scope) {
-    return (TCppObject_t)::operator new(Cpp::SizeOf(scope));
+  TCppObject_t Allocate(TCppScope_t scope, TCppIndex_t count) {
+    return (TCppObject_t)::operator new(Cpp::SizeOf(scope) * count);


warning: no header providing "operator new" is directly included [misc-include-cleaner]

lib/Interpreter/CppInterOp.cpp:39:

- #if CLANG_VERSION_MAJOR >= 19 + #include <new> + #if CLANG_VERSION_MAJOR >= 19

github-actions · 2025-05-21T16:53:45Z

lib/Interpreter/CppInterOp.cpp

-    ::operator delete(address);
+  void Deallocate(TCppScope_t scope, TCppObject_t address, TCppIndex_t count) {
+    size_t bytes = Cpp::SizeOf(scope) * count;
+    ::operator delete(address, bytes);


warning: no header providing "operator delete" is directly included [misc-include-cleaner]

::operator delete(address, bytes); ^

github-actions · 2025-05-21T16:53:45Z

lib/Interpreter/CppInterOp.cpp

@@ -3596,7 +3633,8 @@
    auto* const Ctor = GetDefaultConstructor(interp, Class);
    if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
      if (arena) {
-        JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+        JC.Invoke(&arena, {}, (void*)~0,


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

JC.Invoke(&arena, {}, (void*)~0, ^

github-actions · 2025-05-21T16:53:46Z

lib/Interpreter/CppInterOp.cpp

@@ -3596,7 +3633,8 @@
    auto* const Ctor = GetDefaultConstructor(interp, Class);
    if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
      if (arena) {
-        JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+        JC.Invoke(&arena, {}, (void*)~0,


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

JC.Invoke(&arena, {}, (void*)~0, ^

github-actions · 2025-05-21T16:53:46Z

lib/Interpreter/CppInterOp.cpp

@@ -3596,7 +3633,8 @@
    auto* const Ctor = GetDefaultConstructor(interp, Class);
    if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
      if (arena) {
-        JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+        JC.Invoke(&arena, {}, (void*)~0,


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.Invoke(&arena, {}, (void*)~0, ^

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 22. Check the log or trigger a new build to see more.

include/CppInterOp/CppInterOp.h

github-actions · 2025-06-02T13:55:03Z

include/CppInterOp/CppInterOp.h

@@ -768,19 +798,24 @@ enum : long int {
 CPPINTEROP_API std::vector<long int> GetDimensions(TCppType_t type);

 /// Allocates memory for a given class.
-CPPINTEROP_API TCppObject_t Allocate(TCppScope_t scope);
+/// \c count is used to indicate the number of objects to allocate for.
+CPPINTEROP_API TCppObject_t Allocate(TCppScope_t scope,


warning: enum '(unnamed enum at /github/workspace/include/CppInterOp/CppInterOp.h:802:1)' uses a larger base type ('long', size: 8 bytes) than necessary for its value set, consider using 'std::int8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

enum : long int { ^

We should adjust the types to match the signature types to match the generated code types and disable the clang-tidy complaints if we have to.

This enum is unrelated to this PR or Cpp::Construct not sure why clang-tidy complains about it

lib/CppInterOp/CppInterOp.cpp

github-actions · 2025-06-02T13:55:03Z

lib/CppInterOp/CppInterOp.cpp

@@ -2831,6 +2904,13 @@ CPPINTEROP_API JitCall MakeFunctionCallable(TInterp_t I,
    return {};
  }

+  if (const auto* Ctor = dyn_cast<CXXConstructorDecl>(D)) {
+    if (auto Wrapper = make_wrapper(*interp, cast<FunctionDecl>(D)))


warning: no header providing "std::make_pair" is directly included [misc-include-cleaner]

gDtorWrapperStore.insert(make_pair(D, F)); ^

lib/CppInterOp/CppInterOp.cpp

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 20. Check the log or trigger a new build to see more.

include/CppInterOp/CppInterOp.h

lib/CppInterOp/CppInterOp.cpp

github-actions · 2025-06-02T14:05:46Z

lib/CppInterOp/CppInterOp.cpp

+           "Number of objects to construct/destruct should be atleast 1");
+
+  if (Cpp::IsConstructor(m_FD)) {
+    const auto* CD = cast<CXXConstructorDecl>((const Decl*)m_FD);


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

const auto* CD = cast<CXXConstructorDecl>((const Decl*)m_FD); ^

lib/CppInterOp/CppInterOp.cpp

github-actions · 2025-06-02T14:05:47Z

lib/CppInterOp/CppInterOp.cpp

@@ -3613,33 +3694,36 @@ TCppObject_t Construct(compat::Interpreter& interp, TCppScope_t scope,
  auto* const Ctor = GetDefaultConstructor(interp, Class);
  if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
    if (arena) {
-      JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+      JC.InvokeConstructor(&arena, count, {},


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&arena, count, {}, ^

github-actions · 2025-06-02T14:05:47Z

lib/CppInterOp/CppInterOp.cpp

      return arena;
    }

    void* obj = nullptr;
-    JC.Invoke(&obj);
+    JC.InvokeConstructor(&obj, count, {}, false);


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&obj, count, {}, false); ^

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 15. Check the log or trigger a new build to see more.

include/CppInterOp/CppInterOp.h

github-actions · 2025-06-03T10:21:21Z

lib/CppInterOp/CppInterOp.cpp

@@ -3613,33 +3694,36 @@ TCppObject_t Construct(compat::Interpreter& interp, TCppScope_t scope,
  auto* const Ctor = GetDefaultConstructor(interp, Class);
  if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
    if (arena) {
-      JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+      JC.InvokeConstructor(&arena, count, {},
+                           (void*)~0); // Tell Invoke to use placement new.


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

(void*)~0); // Tell Invoke to use placement new. ^

github-actions · 2025-06-03T10:21:21Z

lib/CppInterOp/CppInterOp.cpp

@@ -3613,33 +3694,36 @@
  auto* const Ctor = GetDefaultConstructor(interp, Class);
  if (JitCall JC = MakeFunctionCallable(&interp, Ctor)) {
    if (arena) {
-      JC.Invoke(&arena, {}, (void*)~0); // Tell Invoke to use placement new.
+      JC.InvokeConstructor(&arena, count, {},
+                           (void*)~0); // Tell Invoke to use placement new.


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

(void*)~0); // Tell Invoke to use placement new. ^

github-actions · 2025-06-03T10:21:21Z

lib/CppInterOp/CppInterOp.cpp

      return arena;
    }

    void* obj = nullptr;
-    JC.Invoke(&obj);
+    JC.InvokeConstructor(&obj, count, {}, nullptr);


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&obj, count, {}, nullptr); ^

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions

clang-tidy made some suggestions

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions · 2025-06-09T18:54:27Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  testing::internal::CaptureStdout();
+
+  // destruct the rest
+  auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +


warning: 'auto new_head' can be declared as 'auto *new_head' [llvm-qualified-auto]

Suggested change

auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +

auto *new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +

github-actions · 2025-06-09T18:54:27Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  testing::internal::CaptureStdout();
+
+  // destruct the rest
+  auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) + ^

github-actions · 2025-06-09T18:54:27Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  testing::internal::CaptureStdout();
+
+  // destruct the rest
+  auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

auto new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) + ^

unittests/CppInterOp/FunctionReflectionTest.cpp

vgvassilev

Looks like we are heading in a good direction. Let's make clang-tidy and codecov happy first.

include/CppInterOp/CppInterOp.h

lib/CppInterOp/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-12T10:18:44Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  testing::internal::CaptureStdout();
+
+  // destruct the rest
+  auto *new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

auto *new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) + ^

github-actions · 2025-06-12T10:18:44Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  testing::internal::CaptureStdout();
+
+  // destruct the rest
+  auto *new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) +


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

auto *new_head = reinterpret_cast<void*>(reinterpret_cast<char*>(where) + ^

vgvassilev · 2025-06-12T11:55:18Z

lib/CppInterOp/CppInterOp.cpp

+  if (N) {
+    callbuf << "(";


I'd move that in the loop, maybe it improves readability...

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-12T12:08:12Z

lib/CppInterOp/CppInterOp.cpp

    return obj;
  }
  return nullptr;
 }

-TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/) {
-  return Construct(getInterp(), scope, arena);
+TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/,


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&arena, count, {}, ^

github-actions · 2025-06-12T12:08:12Z

lib/CppInterOp/CppInterOp.cpp

-TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/) {
-  return Construct(getInterp(), scope, arena);
+TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/,
+                       TCppIndex_t count /*=1UL*/) {


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

(void*)~0); // Tell Invoke to use placement new. ^

github-actions · 2025-06-12T12:08:12Z

lib/CppInterOp/CppInterOp.cpp

-TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/) {
-  return Construct(getInterp(), scope, arena);
+TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/,
+                       TCppIndex_t count /*=1UL*/) {


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

(void*)~0); // Tell Invoke to use placement new. ^

github-actions · 2025-06-12T12:08:12Z

lib/CppInterOp/CppInterOp.cpp

 }

 void Destruct(compat::Interpreter& interp, TCppObject_t This, Decl* Class,
-              bool withFree) {
+              bool withFree, TCppIndex_t nary) {


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&obj, count, {}, nullptr); ^

github-actions · 2025-06-12T12:08:13Z

lib/CppInterOp/CppInterOp.cpp

  auto* Class = static_cast<Decl*>(scope);
-  Destruct(getInterp(), This, Class, withFree);
+  Destruct(getInterp(), This, Class, withFree, count);


warning: function 'Destruct' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

Destruct(getInterp(), This, Class, withFree, count);

static void Destruct(compat::Interpreter& interp, TCppObject_t This, Decl* Class,

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-13T09:20:45Z

lib/CppInterOp/CppInterOp.cpp

    return obj;
  }
  return nullptr;
 }

-TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/) {
-  return Construct(getInterp(), scope, arena);
+TCppObject_t Construct(TCppScope_t scope, void* arena /*=nullptr*/,


warning: no header providing "operator delete" is directly included [misc-include-cleaner]

::operator delete(address, bytes); ^

github-actions · 2025-06-13T09:20:45Z

lib/CppInterOp/CppInterOp.cpp

 }

 void Destruct(compat::Interpreter& interp, TCppObject_t This, Decl* Class,
-              bool withFree) {
+              bool withFree, TCppIndex_t nary) {


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

auto* Class = (Decl*)scope; ^

github-actions · 2025-06-13T09:20:45Z

lib/CppInterOp/CppInterOp.cpp

    return;
  }
  // FIXME: Diagnose.
 }

-void Destruct(TCppObject_t This, TCppScope_t scope, bool withFree /*=true*/) {
+void Destruct(TCppObject_t This, TCppScope_t scope, bool withFree /*=true*/,


warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]

JC.InvokeConstructor(&arena, count, {}, ^

lib/CppInterOp/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions · 2025-06-13T13:32:43Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  EXPECT_TRUE(scope);
+  Cpp::TCppObject_t object = Cpp::Construct(scope);
+  EXPECT_TRUE(object != nullptr);
+  int* fInt = reinterpret_cast<int*>(reinterpret_cast<char*>(object));


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

int* fInt = reinterpret_cast<int*>(reinterpret_cast<char*>(object)); ^

github-actions · 2025-06-13T13:32:44Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  EXPECT_TRUE(scope);
+  Cpp::TCppObject_t object = Cpp::Construct(scope);
+  EXPECT_TRUE(object != nullptr);
+  int* fInt = reinterpret_cast<int*>(reinterpret_cast<char*>(object));


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

int* fInt = reinterpret_cast<int*>(reinterpret_cast<char*>(object)); ^

unittests/CppInterOp/FunctionReflectionTest.cpp

github-actions · 2025-06-13T13:32:44Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  object = Cpp::Construct(scope);
+  EXPECT_TRUE(object);
+  double* fDouble =
+      reinterpret_cast<double*>(reinterpret_cast<char*>(object) + sizeof(int));


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

reinterpret_cast<double*>(reinterpret_cast<char*>(object) + sizeof(int)); ^

github-actions · 2025-06-13T13:32:44Z

unittests/CppInterOp/FunctionReflectionTest.cpp

+  object = Cpp::Construct(scope);
+  EXPECT_TRUE(object);
+  double* fDouble =
+      reinterpret_cast<double*>(reinterpret_cast<char*>(object) + sizeof(int));


warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]

reinterpret_cast<double*>(reinterpret_cast<char*>(object) + sizeof(int)); ^

This catches 0 objects to construct/destruct and attempting array new with requried initialization parameters

vgvassilev · 2025-06-16T10:26:57Z

include/CppInterOp/CppInterOp.h

-  CPPINTEROP_API bool AreArgumentsValid(void* result, ArgList args,
-                                        void* self) const;
+  CPPINTEROP_API bool AreArgumentsValid(void* result, ArgList args, void* self,
+                                        size_t nary = 1UL) const;


We will need a comment explaining why this is the default magic value.

aaronj0 requested a review from vgvassilev May 21, 2025 15:37

aaronj0 force-pushed the structor-api branch from 0160cf1 to 21f1617 Compare May 21, 2025 15:46

aaronj0 force-pushed the structor-api branch from 21f1617 to 624bfb1 Compare May 21, 2025 16:46

aaronj0 marked this pull request as draft May 21, 2025 16:47

github-actions bot reviewed May 21, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch 2 times, most recently from 0b3d49d to b6d01ac Compare June 2, 2025 13:54

github-actions bot reviewed Jun 2, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch from b6d01ac to 66e77df Compare June 2, 2025 13:55

aaronj0 marked this pull request as ready for review June 2, 2025 13:56

github-actions bot reviewed Jun 2, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch from 66e77df to cf533ca Compare June 3, 2025 10:12

github-actions bot reviewed Jun 3, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch from cf533ca to 7596735 Compare June 9, 2025 18:45

github-actions bot reviewed Jun 9, 2025

View reviewed changes

vgvassilev reviewed Jun 10, 2025

View reviewed changes

include/CppInterOp/CppInterOp.h Outdated Show resolved Hide resolved

include/CppInterOp/CppInterOp.h Show resolved Hide resolved

include/CppInterOp/CppInterOp.h Show resolved Hide resolved

lib/CppInterOp/CppInterOp.cpp Show resolved Hide resolved

aaronj0 force-pushed the structor-api branch from 7596735 to b71002c Compare June 12, 2025 10:08

github-actions bot reviewed Jun 12, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch from b71002c to a420064 Compare June 12, 2025 10:55

aaronj0 mentioned this pull request Jun 12, 2025

adapt to changes in JitCall, use InvokeConstructor in CallWrapper, compiler-research/cppyy-backend#149

Open

aaronj0 force-pushed the structor-api branch from a420064 to 5274fd8 Compare June 12, 2025 11:49

vgvassilev reviewed Jun 12, 2025

View reviewed changes

github-actions bot reviewed Jun 12, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch 2 times, most recently from 8429b98 to f3a20b2 Compare June 13, 2025 09:00

github-actions bot reviewed Jun 13, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch 3 times, most recently from 6b8b67c to 9640f34 Compare June 13, 2025 13:31

github-actions bot reviewed Jun 13, 2025

View reviewed changes

aaronj0 force-pushed the structor-api branch 3 times, most recently from 8c563b3 to 4218a88 Compare June 13, 2025 13:38

aaronj0 added 6 commits June 16, 2025 07:51

Array of objects in Construct/Destruct/Allocate/Deallocate

ee6e034

Use array new for codegen in JitCall

f2b0b48

Implement ConstructorCall in JitCall, disentangled from generics

dc1740b

Add extra diagnostics in JitCall::AreArgumentsValid

ef73c8f

This catches 0 objects to construct/destruct and attempting array new with requried initialization parameters

[test] ConstructArray, DestructArray, Allocate and Deallocate

d4b8475

Add tests for debug-only=jitcall

cb1a9bc

aaronj0 force-pushed the structor-api branch from 4218a88 to cb1a9bc Compare June 16, 2025 06:09

aaronj0 mentioned this pull request Jun 16, 2025

Add onto existing suppression for clang18 compiler-research/cppyy#151

Merged

vgvassilev reviewed Jun 16, 2025

View reviewed changes

	return InvokeDestructor(result, nary, /withFree=/true);
	{ InvokeDestructor(result, nary, /withFree=/true); return;
	}

	auto new_head = reinterpret_cast<void>(reinterpret_cast<char>(where) +
	auto new_head = reinterpret_cast<void>(reinterpret_cast<char*>(where) +

	Destruct(getInterp(), This, Class, withFree, count);
	static void Destruct(compat::Interpreter& interp, TCppObject_t This, Decl* Class,

Add support for array of objects in Construct/Destruct #587

Are you sure you want to change the base?

Add support for array of objects in Construct/Destruct #587

Uh oh!

Conversation

aaronj0 commented May 21, 2025

Uh oh!

codecov bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

vgvassilev Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

aaronj0 Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 21, 2025 •

edited

Loading