Skip to content

[ci] Make building native llvm into reusable action #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 2, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR turns the building of llvm on native platforms into a reusable action

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton requested a review from vgvassilev June 2, 2025 11:30
@mcbarton mcbarton force-pushed the make-llvm-build-reusable-action branch from afb6b41 to 917638d Compare June 2, 2025 11:33
@mcbarton mcbarton marked this pull request as draft June 2, 2025 11:37
@mcbarton mcbarton force-pushed the make-llvm-build-reusable-action branch 3 times, most recently from 26c8fdf to 897099f Compare June 2, 2025 12:50
@mcbarton mcbarton force-pushed the make-llvm-build-reusable-action branch from 3f793d6 to df09eac Compare June 2, 2025 12:52
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cd ../..
fi
- uses: ./.github/actions/Build_LLVM
with:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of an input for my reusable action seems a bit of hack, but I couldn't get the reusable action to have access to 'steps.cache.outputs.cache-hit' otherwise. Will fix in a later PR which refines the actions.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 2, 2025

I will merge once all workflows have passed the build cache stage of the workflows (want to check nothing unexpected happens).

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.58%. Comparing base (aeb6137) to head (df09eac).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files           9        9           
  Lines        3734     3734           
=======================================
  Hits         2897     2897           
  Misses        837      837           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton marked this pull request as ready for review June 2, 2025 13:47
@mcbarton mcbarton merged commit 7f33134 into compiler-research:main Jun 2, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants