fix: codegen for nested namespace with using #612
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 77.48% 77.66% +0.18%
==========================================
Files 9 9
Lines 3713 3743 +30
==========================================
+ Hits 2877 2907 +30
Misses 836 836
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -518,7 +518,13 @@ std::string GetQualifiedCompleteName(TCppType_t klass) { | |||
| if (auto* TD = llvm::dyn_cast<TagDecl>(ND)) { | |||
| std::string type_name; | |||
| QualType QT = C.getTagDeclType(TD); | |||
| QT.getAsStringInternal(type_name, C.getPrintingPolicy()); | |||
| PrintingPolicy PP = C.getPrintingPolicy(); | |||
| PP.FullyQualifiedName = true; | |||
There was a problem hiding this comment.
Can we make sure codecov is covered?
There was a problem hiding this comment.
This might be a problem with codecov, because the line above and below is covered, and there is no conditional either.
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -1733,6 +1733,53 @@ TEST(FunctionReflectionTest, GetFunctionCallWrapper) { | |||
| Cpp::BestOverloadFunctionMatch(operators, {}, {K1, K2}); | |||
| auto chrono_op_fn_callable = Cpp::MakeFunctionCallable(kop); | |||
| EXPECT_EQ(chrono_op_fn_callable.getKind(), Cpp::JitCall::kGenericCall); | |||
|
|
|||
| Interp->process(R"( | |||
| #include <tuple> | |||
There was a problem hiding this comment.
Can we avoid the inclusion of the header and craft our own make_tuple-like routine? That should avoid future problems when CppInterOp tests are ran without installed stl.
|
clang-tidy review says "All clean, LGTM! 👍" |
Enables 3 tests in cppyy.