Skip to content

fix codegen & instantiation of templated function with rvalue as parameter #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Vipul-Cariappa
Copy link
Collaborator

Description

Enables func(std::move(args)) when func is templated.

Fixes # (issue)

Fixes a test in cppy.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Included

Checklist

  • I have read the contribution guide recently

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (7bb23b9) to head (5228f93).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   77.96%   78.00%   +0.03%     
==========================================
  Files           9        9              
  Lines        3767     3769       +2     
==========================================
+ Hits         2937     2940       +3     
+ Misses        830      829       -1     
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 85.62% <100.00%> (+0.06%) ⬆️
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 85.62% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vipul-Cariappa Vipul-Cariappa changed the title Templated function with rvalue as parameter fix codegen & instantiation of templated function with rvalue as parameter Jun 13, 2025
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Vipul-Cariappa Vipul-Cariappa merged commit 28abd17 into compiler-research:main Jun 16, 2025
50 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the dev/templ-func-move branch June 16, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants