Skip to content

Attempt to removed xtl dependency #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anutosh491
Copy link
Collaborator

Fixes #108

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.45%. Comparing base (e788167) to head (1042afb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   62.66%   63.45%   +0.79%     
==========================================
  Files          15       15              
  Lines         600      613      +13     
  Branches       59       60       +1     
==========================================
+ Hits          376      389      +13     
  Misses        224      224              
Files Coverage Δ
src/xinspect.hpp 69.49% <ø> (ø)
src/xinterpreter.cpp 88.30% <100.00%> (+0.96%) ⬆️
src/xutils.cpp 78.57% <ø> (ø)
Files Coverage Δ
src/xinspect.hpp 69.49% <ø> (ø)
src/xinterpreter.cpp 88.30% <100.00%> (+0.96%) ⬆️
src/xutils.cpp 78.57% <ø> (ø)

@anutosh491 anutosh491 marked this pull request as draft May 21, 2024 12:56
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator Author

Hmm wait, I think pertaining to this line
https://github.com/jupyter-xeus/xeus/blob/1bbef7208ed3d92a90eadce752d3b56b7636f920/xeusConfig.cmake.in#L25, we might not be able to drop the dependency of xtl from xeus-cpp ( The dependency chain might be xeus-cpp -> xeus-zmq -> xeus -> xtl)

@vgvassilev
Copy link
Contributor

Ah, that's a good point... :(

@JohanMabille
Copy link
Collaborator

I think most of the features we use from the xtl are actually specific to xeus, meaning we could actually move or duplicate the code in xeus. I'm not 100% sure though.

@anutosh491 anutosh491 mentioned this pull request May 31, 2024
anutosh491 added a commit to anutosh491/xeus-cpp that referenced this pull request Jun 3, 2024
@vgvassilev vgvassilev closed this in a2841c6 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the dependency on xtl
4 participants