Skip to content

Removing dirent dependency #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented May 22, 2024

I don't think we use dirent for windows build anymore and can be removed.

@anutosh491 anutosh491 requested a review from vgvassilev May 22, 2024 09:26
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (6692a45) to head (031546d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files          17       17           
  Lines         602      602           
  Branches       59       59           
=======================================
  Hits          422      422           
  Misses        180      180           

@vgvassilev vgvassilev requested a review from mcbarton May 22, 2024 19:17
Copy link
Collaborator

@mcbarton mcbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anutosh491 Unless we are expecting people to install versions 0.0.1-0.3.0 then its probably worth removing these from the readme. Also I don't know at which point the direct requirement for Windows builds was removed, so another reason to remove the old versions from the table.

@anutosh491
Copy link
Collaborator Author

anutosh491 commented May 23, 2024

Ahh okay got you. So only 0.0.1 uses dirent and dirent was removed through this commit dated back to July 22, 2023 and 0.1.0 was out by Nov, 2023. So I think we can get rid of the first patch version.

Unless we are expecting people to install versions 0.0.1-0.3.0 then its probably worth removing these from the readme

Also yes, most repos from the xeus-stack keep track of minor versions so we'll keep that for now.

@anutosh491 anutosh491 requested a review from mcbarton May 23, 2024 05:46
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit c7a3175 into compiler-research:main May 23, 2024
8 checks passed
@anutosh491 anutosh491 deleted the dirent branch May 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants