Skip to content

Add Jupyter Lite serve instructions to README #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

The objective of this PR is to see whether the jupyter serve issue mention here is present in the wasm build in the ci #61 (comment)

@mcbarton mcbarton changed the title Debug jupyter lite server Debug Jupyter Lite serve May 23, 2024
@anutosh491
Copy link
Collaborator

Thanks for this. Let's see what the CI says !

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (c7a3175) to head (abae6bb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          17       17           
  Lines         602      602           
  Branches       59       59           
=======================================
  Hits          452      452           
  Misses        150      150           

@mcbarton mcbarton marked this pull request as draft May 23, 2024 10:37
@mcbarton mcbarton force-pushed the debug-jupyter-lite-server branch from 5b95524 to abae6bb Compare May 23, 2024 11:32
@mcbarton mcbarton marked this pull request as ready for review May 23, 2024 11:33
@mcbarton mcbarton changed the title Debug Jupyter Lite serve Add Jupyter Lite serve instructions to README May 23, 2024
@mcbarton
Copy link
Collaborator Author

@anutosh491 here is the PR for you to review once you've had a chance to test locally.

@vgvassilev vgvassilev requested a review from anutosh491 May 24, 2024 05:57
@anutosh491
Copy link
Collaborator

Trying it out now !

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Thanks for this :)
Merging !

@anutosh491 anutosh491 merged commit ef0992a into compiler-research:main May 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants