-
Notifications
You must be signed in to change notification settings - Fork 36
Update example notebook #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example notebook #121
Conversation
@anutosh491, @mcbarton, @tharun571, is there a way to run these demos as part of the tests? This way we are guaranteed they will work. |
Some parts of it are already being run as part of the tests in Jupyter Kernel Test, so should be possible. It won't work on Windows until the reason why XCppTests fails has been determined. |
Yes I haven't used the jupyter-kernel-test library personally (https://github.com/jupyter/jupyter_kernel_test) but I guess that is used to test out kernels. As Matthew says the XCppTests do cover some features like displaying the image etc |
In my very naive imagination we can/should have some binary that takes a notebook as parameter and returns some jsons for the results... If we don't have such a thing probably that's easy to implement. I think such a thing is critical to make sure xeus-cpp works consistently over time... |
Yeah that makes sense. I have the following thoughts
cc @vgvassilev @mcbarton if you're thoughts match with mine, you can maybe review and merge and I'll address the 1st point then. |
Ok, let’s open an issue for this and move forward with the pr. |
Raised an issue here ##122 |
As we plan to deprecate xeus-cling once we release
1.0.0
, I think it makes sense to update our example notebook with most of what xeus-cling's example notebook supports.I think we have most of what is required except Magics and Xtensor support.