Skip to content

doc: Fix micromamba development environment creation command #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2024
Merged

doc: Fix micromamba development environment creation command #141

merged 2 commits into from
Jun 5, 2024

Conversation

MashyBasker
Copy link
Contributor

Description

Following the development environment creation command in CONTRIBUTING.md using micromamba gives the following error:

╭─okabe@basu ~/open-source/xeus-cpp ‹fix-build-instruction› 
╰─$ micromamba create -n xeus-cpp environment-dev.yml   
conda-forge/linux-64                                        Using cache
conda-forge/noarch                                          Using cache
nodefaults/linux-64                                           No change
nodefaults/noarch                                             No change
error    libmamba Could not solve for environment specs
    The following package could not be installed
    └─ environment-dev.yml does not exist (perhaps a typo or a missing channel).
critical libmamba Could not solve for environment specs

The command should be updated to use the -f to use the environment-dev.yml file.

Fixes # (issue)
N/A

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@vgvassilev vgvassilev requested a review from mcbarton June 5, 2024 06:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (7e5b820) to head (dc9bf95).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          17       17           
  Lines         612      612           
  Branches       59       59           
=======================================
  Hits          486      486           
  Misses        126      126           

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

CONTRIBUTING.md Outdated
@@ -31,7 +31,7 @@ or miniconda installed cd into the xeus-cpp directory and set setup your environ

```bash
cd xeus-cpp
micromamba create -n xeus-cpp environment-dev.yml
micromamba create -n xeus-cpp -f environment-dev.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
micromamba create -n xeus-cpp -f environment-dev.yml
micromamba create -f environment-dev.yml -y

Copy link
Collaborator

@mcbarton mcbarton Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MashyBasker This change just allows us to offer similar instructions between wasm and non wasm builds. To see wasm instructions I am referencing see thr readme.

@mcbarton mcbarton merged commit edd830f into compiler-research:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants