Skip to content

Stop fetching emsdk from conda-forge #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Nov 5, 2024

Description

emsdk's recipe from conda-forge is no longer being maintained. Hence preferably we should clone it and install it accordingly.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (e9df705) to head (426ce27).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          19       19           
  Lines         973      973           
  Branches       93       93           
=======================================
  Hits          786      786           
  Misses        187      187           

@mcbarton
Copy link
Collaborator

@anutosh491 why are we still using 3.1.45 when the latest version is 3.1.71?

@anutosh491
Copy link
Collaborator Author

Hi @mcbarton

I discussed the need for this PR on discord (pasting the link here)
Let me know if can't access it, in that case I shall paste the contents here.

Also answering your question. The whole jupyter stack (xeus, xeus kernels and compiler/interpreter frameworks in the backend) all are compiled against either 3.1.45 or 3.1.58 when being hosted on emscripten-forge. It is also generally recommended to have the whole toolchain built against the same version. So now that xeus and cppinterop are built against 3.145 as can be seen here it would be best to build the middleware, xeus-cpp against it too.

This is a temporary thing and would be updated to the later version soon (basically when everything moves to the latest version)

@mcbarton mcbarton merged commit a52ab3b into compiler-research:main Nov 29, 2024
8 checks passed
@anutosh491 anutosh491 deleted the emsdk branch November 29, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants