Skip to content

Remove xdemangle as it is redundant #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

faze-geek
Copy link
Contributor

@faze-geek faze-geek commented Nov 18, 2024

Description

Please include a summary of changes, motivation and context for this PR.

Fixes #179

Type of change

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (e9df705) to head (ddf6b32).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          19       19           
  Lines         973      973           
  Branches       93       93           
=======================================
  Hits          786      786           
  Misses        187      187           
Files with missing lines Coverage Δ
src/xinspect.hpp 82.83% <ø> (ø)
Files with missing lines Coverage Δ
src/xinspect.hpp 82.83% <ø> (ø)

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good merging

@anutosh491 anutosh491 merged commit b1f9f75 into compiler-research:main Nov 18, 2024
9 checks passed
@faze-geek faze-geek deleted the remove_xdemangle branch November 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is xdemangle.hpp redundant ?
4 participants